Skip to content

London | 26-ITP-JAN | Kayanat Suleman | Sprint 1 | Wireframe#1087

Open
KayanatSuleman wants to merge 13 commits intoCodeYourFuture:mainfrom
KayanatSuleman:feature/wireframe
Open

London | 26-ITP-JAN | Kayanat Suleman | Sprint 1 | Wireframe#1087
KayanatSuleman wants to merge 13 commits intoCodeYourFuture:mainfrom
KayanatSuleman:feature/wireframe

Conversation

@KayanatSuleman
Copy link

@KayanatSuleman KayanatSuleman commented Jan 27, 2026

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

  • Updated the page header title and description to match the wireframe requirements
  • Added three unique articles with image, title, summary, and external link
  • Structured the page using semantic HTML (header, main, section, article, footer)
  • Fixed footer CSS and pinned the footer to the bottom of the viewport
  • Checked Lighthouse Accessibility score (100)

Questions

None so far, happy to amend. Thank you for reviewing.

@netlify
Copy link

netlify bot commented Jan 27, 2026 •
edited
Loading

✅ Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit 5a63067
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/6984eb7c7736960008cce4b6
😎 Deploy Preview https://deploy-preview-1087--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@KayanatSuleman KayanatSuleman added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Onboarding The name of the module. labels Jan 27, 2026
This was referenced Jan 27, 2026
Open
Open
MorganDavid
MorganDavid reviewed Jan 31, 2026
View reviewed changes
@MorganDavid MorganDavid added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jan 31, 2026
@KayanatSuleman KayanatSuleman added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Feb 4, 2026
@KayanatSuleman
Copy link
Author

KayanatSuleman commented Feb 5, 2026 •
edited
Loading

Hi @MorganDavid @cjyuan I have updated the script with the necessary changed. Please review! Thank you.

@cjyuan
Copy link
Contributor

cjyuan commented Feb 5, 2026

@KayanatSuleman Not sure what you summoned me here.

I took a quick look at the deployed page, and here's what I would suggest:

  • To better align with the wireframe, you should center the PAGE TITLE and the SHORT DESCRIPTION beneath it on the page.
  • Prevent the footer from covering part of the last two articles (on desktop view or when zoomed in).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@MorganDavid MorganDavid MorganDavid left review comments

Reviewers whose approvals may not affect merge requirements

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

Module-Onboarding The name of the module. Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@KayanatSuleman @cjyuan @MorganDavid